Commit @cf815218f5983fa1d7be9cd34728d8f589b8d465

doortts 2013-04-17

test: divide case and add suitable tests

@cf815218f5983fa1d7be9cd34728d8f589b8d465

39708b2

cf81521

test/utils/AccessControlTest.java

--- test/utils/AccessControlTest.java

+++ test/utils/AccessControlTest.java


 package utils;
 
 import models.*;
-import models.Posting;
 
 import org.junit.Test;
 
-import controllers.UserApp;
 import static org.fest.assertions.Assertions.assertThat;
 
 import models.enumeration.Operation;
-import play.db.ebean.Model.Finder;
 
 public class AccessControlTest extends ModelTest<Role>{
     @Test
-    public void isAllowed() {
+    public void isAllowed_siteAdmin() {
         // Given
         User admin = User.findByLoginId("admin");
-        User hobi = User.findByLoginId("hobi");
         Project nforge4java = Project.findByNameAndOwner("hobi", "nForge4java");
-        Project jindo = Project.findByNameAndOwner("k16wire", "Jindo");
 
         // When
-        boolean result1 = AccessControl.isAllowed(admin, nforge4java.asResource(), Operation.UPDATE);
-        boolean result2 = AccessControl.isAllowed(hobi, jindo.asResource(), Operation.UPDATE);
-        boolean result3 = AccessControl.isAllowed(UserApp.anonymous, jindo.asResource(), Operation.READ);
+        boolean canUpdate = AccessControl.isAllowed(admin, nforge4java.asResource(), Operation.UPDATE);
+        boolean canRead = AccessControl.isAllowed(admin, nforge4java.asResource(), Operation.READ);
+        boolean canDelete = AccessControl.isAllowed(admin, nforge4java.asResource(), Operation.DELETE);
 
         // Then
-        assertThat(result1).isEqualTo(true);
-        assertThat(result2).isEqualTo(false);
-        assertThat(result3).isEqualTo(false);
+        assertThat(canRead).isEqualTo(true);
+        assertThat(canUpdate).isEqualTo(true);
+        assertThat(canDelete).isEqualTo(true);
+    }
+
+    @Test
+    public void isAllowed_projectCreator() {
+        // Given
+        User hobi = User.findByLoginId("hobi");
+        Project nforge4java = Project.findByNameAndOwner("hobi", "nForge4java");
+
+        // When
+        boolean canUpdate = AccessControl.isAllowed(hobi, nforge4java.asResource(), Operation.UPDATE);
+        boolean canRead = AccessControl.isAllowed(hobi, nforge4java.asResource(), Operation.READ);
+        boolean canDelete = AccessControl.isAllowed(hobi, nforge4java.asResource(), Operation.DELETE);
+
+        // Then
+        assertThat(canRead).isEqualTo(true);
+        assertThat(canUpdate).isEqualTo(true);
+        assertThat(canDelete).isEqualTo(true);
+    }
+
+    @Test
+    public void isAllowed_notAMember() {
+        // Given
+        User notMember = User.findByLoginId("nori");
+        Project nforge4java = Project.findByNameAndOwner("hobi", "nForge4java");
+
+        // When
+        boolean canUpdate = AccessControl.isAllowed(notMember, nforge4java.asResource(), Operation.UPDATE);
+        boolean canRead = AccessControl.isAllowed(notMember, nforge4java.asResource(), Operation.READ);
+        boolean canDelete = AccessControl.isAllowed(notMember, nforge4java.asResource(), Operation.DELETE);
+
+        // Then
+        assertThat(canRead).isEqualTo(true);
+        assertThat(canUpdate).isEqualTo(false);
+        assertThat(canDelete).isEqualTo(false);
     }
 }

Add a comment

Open 0
Closed 0

List

...	...	@@ -1,33 +1,62 @@
1	1	package utils;
2	2
3	3	import models.*;
4		-import models.Posting;
5	4
6	5	import org.junit.Test;
7	6
8		-import controllers.UserApp;
9	7	import static org.fest.assertions.Assertions.assertThat;
10	8
11	9	import models.enumeration.Operation;
12		-import play.db.ebean.Model.Finder;
13	10
14	11	public class AccessControlTest extends ModelTest<Role>{
15	12	@Test
16		- public void isAllowed() {
	13	+ public void isAllowed_siteAdmin() {
17	14	// Given
18	15	User admin = User.findByLoginId("admin");
19		- User hobi = User.findByLoginId("hobi");
20	16	Project nforge4java = Project.findByNameAndOwner("hobi", "nForge4java");
21		- Project jindo = Project.findByNameAndOwner("k16wire", "Jindo");
22	17
23	18	// When
24		- boolean result1 = AccessControl.isAllowed(admin, nforge4java.asResource(), Operation.UPDATE);
25		- boolean result2 = AccessControl.isAllowed(hobi, jindo.asResource(), Operation.UPDATE);
26		- boolean result3 = AccessControl.isAllowed(UserApp.anonymous, jindo.asResource(), Operation.READ);
	19	+ boolean canUpdate = AccessControl.isAllowed(admin, nforge4java.asResource(), Operation.UPDATE);
	20	+ boolean canRead = AccessControl.isAllowed(admin, nforge4java.asResource(), Operation.READ);
	21	+ boolean canDelete = AccessControl.isAllowed(admin, nforge4java.asResource(), Operation.DELETE);
27	22
28	23	// Then
29		- assertThat(result1).isEqualTo(true);
30		- assertThat(result2).isEqualTo(false);
31		- assertThat(result3).isEqualTo(false);
	24	+ assertThat(canRead).isEqualTo(true);
	25	+ assertThat(canUpdate).isEqualTo(true);
	26	+ assertThat(canDelete).isEqualTo(true);
	27	+ }
	28	+
	29	+ @Test
	30	+ public void isAllowed_projectCreator() {
	31	+ // Given
	32	+ User hobi = User.findByLoginId("hobi");
	33	+ Project nforge4java = Project.findByNameAndOwner("hobi", "nForge4java");
	34	+
	35	+ // When
	36	+ boolean canUpdate = AccessControl.isAllowed(hobi, nforge4java.asResource(), Operation.UPDATE);
	37	+ boolean canRead = AccessControl.isAllowed(hobi, nforge4java.asResource(), Operation.READ);
	38	+ boolean canDelete = AccessControl.isAllowed(hobi, nforge4java.asResource(), Operation.DELETE);
	39	+
	40	+ // Then
	41	+ assertThat(canRead).isEqualTo(true);
	42	+ assertThat(canUpdate).isEqualTo(true);
	43	+ assertThat(canDelete).isEqualTo(true);
	44	+ }
	45	+
	46	+ @Test
	47	+ public void isAllowed_notAMember() {
	48	+ // Given
	49	+ User notMember = User.findByLoginId("nori");
	50	+ Project nforge4java = Project.findByNameAndOwner("hobi", "nForge4java");
	51	+
	52	+ // When
	53	+ boolean canUpdate = AccessControl.isAllowed(notMember, nforge4java.asResource(), Operation.UPDATE);
	54	+ boolean canRead = AccessControl.isAllowed(notMember, nforge4java.asResource(), Operation.READ);
	55	+ boolean canDelete = AccessControl.isAllowed(notMember, nforge4java.asResource(), Operation.DELETE);
	56	+
	57	+ // Then
	58	+ assertThat(canRead).isEqualTo(true);
	59	+ assertThat(canUpdate).isEqualTo(false);
	60	+ assertThat(canDelete).isEqualTo(false);
32	61	}
33	62	}

Delete comment