Commit @c3dc06a89c5c52abb0b71d960410eccec9e3785c

Y
List All
Feedback

kjkmadness 2014-03-14

hotfix: fix anonymous check logic

- use User#isAnonymous when check a user object is anonymous or not
- add not null constraint on n4user.login_id

@c3dc06a89c5c52abb0b71d960410eccec9e3785c

704f0bc

c3dc06a

app/controllers/IssueApp.java

--- app/controllers/IssueApp.java

+++ app/controllers/IssueApp.java


     }
 
     private static boolean isAnonymousAssignee(Issue issue) {
-        return issue.assignee.user != null && issue.assignee.user.id == User.anonymous.id;
+        return issue.assignee.user != null && issue.assignee.user.isAnonymous();
     }
 
     private static boolean hasAssignee(Issue issue) {

704f0bc

c3dc06a

conf/evolutions/default/67.sql

--- conf/evolutions/default/67.sql

+++ conf/evolutions/default/67.sql


 
 delete from assignee where user_id is null;
 
+alter table n4user alter column login_id set not null;
+
 # --- !Downs
 
+alter table n4user alter column login_id drop not null;

Add a comment

Open 0
Closed 0

List

...	...	@@ -541,7 +541,7 @@
541	541	}
542	542
543	543	private static boolean isAnonymousAssignee(Issue issue) {
544		- return issue.assignee.user != null && issue.assignee.user.id == User.anonymous.id;
	544	+ return issue.assignee.user != null && issue.assignee.user.isAnonymous();
545	545	}
546	546
547	547	private static boolean hasAssignee(Issue issue) {

...	...	@@ -9,5 +9,8 @@
9	9
10	10	delete from assignee where user_id is null;
11	11
	12	+alter table n4user alter column login_id set not null;
	13	+
12	14	# --- !Downs
13	15
	16	+alter table n4user alter column login_id drop not null;

Delete comment