박완순 2014-03-25
Merge branch 'issue/milestone-color' of insanehong/hive
from pull request 729
@9249da0373b443551941f6c4db62a40e1494938e
app/assets/stylesheets/less/_common.less
--- app/assets/stylesheets/less/_common.less
+++ app/assets/stylesheets/less/_common.less
@@ -101,7 +101,7 @@
 }
 
 /** file uploader **/
-.progress {
+.upload-progress {
     height: 7px;
     margin-bottom: 5px;
     background:#b1b1b1;
app/assets/stylesheets/less/_page.less
--- app/assets/stylesheets/less/_page.less
+++ app/assets/stylesheets/less/_page.less
@@ -1956,7 +1956,6 @@
     padding: 4px;
 
     .progress {
-        background-color:@state-open;
         height:7px;
         width:100%;
 
@@ -2021,15 +2020,8 @@
                     color: #666;
                     &.over { color:#f36c22; }
                 }
-
-                .open { background-color: @state-open; color:#FFF;}
-                .closed { background-color: @state-closed; color:#FFF;}
-
-                .num-badge {
-                    color: #fff;
-                    margin-left:3px;
-                }
             }
+            
             .progress-wrap {
                 overflow: hidden;
                 color: #999;
@@ -2037,14 +2029,7 @@
                 margin-top:15px;
 
                 .progress {
-                    background-color: @state-open;
-
-                    &.empty { background-color: #B1B1B1; }
-
-                    .progress-bar {
-                        background-color: @state-closed;
-                        height: inherit;
-                    }
+                    height:14px;
                 }
 
             }
app/views/common/fileUploader.scala.html
--- app/views/common/fileUploader.scala.html
+++ app/views/common/fileUploader.scala.html
@@ -25,7 +25,7 @@
         <strong class="name">${fileName}</strong>
         <span class="size">${fileSizeReadable}</span>
         <div class="progress-wrap pull-right">
-            <div class="progress n4"><div class="bar orange"></div></div>
+            <div class="upload-progress n4"><div class="bar orange"></div></div>
         </div>
         <button type="button" class="btn-transparent btn-delete pull-right">&times;</button>
         <span class="pull-right nbtn small white btn-insert">@Messages("common.attach.clickToPost")</span>
app/views/milestone/list.scala.html
--- app/views/milestone/list.scala.html
+++ app/views/milestone/list.scala.html
@@ -21,12 +21,6 @@
 	)
 }
 
-@makeIssuesLink(mId: Long, _state: String) = @{
-	buildQueryString(routes.IssueApp.issues(project.owner, project.name, _state),
-		Map("milestoneId"->mId.toString)
-	)
-}
-
 @projectLayout(title, project, utils.MenuType.MILESTONE) {
 @projectMenu(project, utils.MenuType.MILESTONE, "")
 <div class="page-wrap-outer">
@@ -61,12 +55,6 @@
     	} else {
 
         <div class="filter-wrap milestone">
-            <div class="milestone-legend pull-left">
-                <i class="open"></i> @Messages("issue.state.open")
-                <i class="closed"></i> @Messages("issue.state.closed")
-
-            </div>
-
             @if(milestones.length > 1){
     		<div class="filters">
     			@makeFilterLink("dueDate", param.orderBy, param.orderDir, Messages("common.order.dueDate"))
@@ -103,38 +91,19 @@
                             </span>
                             }
                         }
-                        <div class="issue-wrap pull-right">
-                            <a href="@makeIssuesLink(milestone.id,"open")" class="ybtn open medium open-issue">
-                                @Messages("issue.state.open") <strong class="num-badge">@milestone.getNumOpenIssues</strong>
-                            </a>
-                            <a href="@makeIssuesLink(milestone.id,"closed")" class="ybtn closed medium closed-issue">
-                                @Messages("issue.state.closed") <strong class="num-badge">@milestone.getNumClosedIssues</strong>
-                            </a>
+                        <div class="pull-right">
+                            <strong class="title">@milestone.getNumClosedIssues / @(milestone.getNumOpenIssues + milestone.getNumClosedIssues)</strong>
                         </div>
                     </div>
 
                     <div class="progress-wrap">
-    					<div class="progress @if(milestone.getCompletionRate==0){empty}">
-    						<div class="progress-bar" style="width: @milestone.getCompletionRate%;"></div>
+    					<div class="progress progress-success progress-striped @if(milestone.state == State.OPEN) {active}">
+    						<div class="bar" style="width: @milestone.getCompletionRate%;"></div>
     					</div>
-
-    					<div class="progress-label">
-                            @if(milestone.getNumOpenIssues + milestone.getNumClosedIssues > 0) {
-    						<div class="pull-left">
-    							<a href="@makeIssuesLink(milestone.id,"closed")">@Messages("issue.state.closed") <strong>@milestone.getCompletionRate%</strong></a>
-    						</div>
-    						<div class="pull-right">
-    							<a href="@makeIssuesLink(milestone.id,"open")">@Messages("issue.state.open") <strong>@{100 - milestone.getCompletionRate}%</strong></a>
-    						</div>
-                            } else {
-                                <div class="empty-issue">@Messages("issue.is.empty")</div>
-                            }
-    					</div>
-
-    				</div>
+                    </div>
                 </div>
 
-                <div class="completion-rate @if(milestone.getCompletionRate == 100){done}">
+                <div class="completion-rate">
                     @if(milestone.getNumOpenIssues + milestone.getNumClosedIssues > 0) {
                     @milestone.getCompletionRate
                     <i>%</i>
app/views/milestone/partial_status.scala.html
--- app/views/milestone/partial_status.scala.html
+++ app/views/milestone/partial_status.scala.html
@@ -5,12 +5,6 @@
 
 @urlToList = {@routes.MilestoneApp.milestones(project.owner, project.name)}
 
-@makeIssuesLink(mId: Long, _state: String) = @{
-    buildQueryString(routes.IssueApp.issues(project.owner, project.name, _state),
-        Map("milestoneId"->mId.toString)
-    )
-}
-
 <div class="milestone-info">
     <div class="meta-info">
         <a href="@routes.MilestoneApp.milestone(project.owner, project.name, milestone.id)" class="title">@milestone.title</a>
@@ -22,16 +16,13 @@
     </div>
 
     <div class="progress-wrap">
-        <div class="progress">
-            <div class="bar orange" style="width: @milestone.getCompletionRate%;"></div>
+        <div class="progress progress-success progress-striped nm">
+            <div class="bar" style="width: @milestone.getCompletionRate%;"></div>
         </div>
         <div class="progress-info">
-            <div class="pull-left" >
-                <a href="@makeIssuesLink(milestone.id,"closed")">@Messages("issue.state.closed") <strong>@milestone.getCompletionRate%</strong></a>
-            </div>
-            <div class="pull-right">
-                <a href="@makeIssuesLink(milestone.id,"open")">@Messages("issue.state.open") <strong>@{100 - milestone.getCompletionRate}%</strong></a>
-            </div>
+            <span class="pull-right">
+                <strong>@milestone.getNumClosedIssues / @(milestone.getNumOpenIssues + milestone.getNumClosedIssues)</strong>
+            </span>
         </div>
     </div>
 </div>
app/views/milestone/view.scala.html
--- app/views/milestone/view.scala.html
+++ app/views/milestone/view.scala.html
@@ -34,22 +34,9 @@
                 </small>
             </h4>
 
-            <div class="progress @if(milestone.getCompletionRate==0){empty}">
-                <div class="progress-bar" style="width: @milestone.getCompletionRate%;"></div>
+            <div class="progress progress-success progress-striped @if(milestone.state == State.OPEN) {active}">
+                <div class="bar" style="width: @milestone.getCompletionRate%;"></div>
             </div>
-            <div class="progress-label clearfix">
-                @if(milestone.getNumOpenIssues + milestone.getNumClosedIssues > 0) {
-                <div class="pull-left">
-                    <a href="@makeIssuesLink(milestone.id,"closed")">@Messages("issue.state.closed") <strong>@milestone.getCompletionRate%</strong></a>
-                </div>
-                <div class="pull-right">
-                    <a href="@makeIssuesLink(milestone.id,"open")">@Messages("issue.state.open") <strong>@{100 - milestone.getCompletionRate}%</strong></a>
-                </div>
-                } else {
-                    <div class="empty-issue">@Messages("issue.is.empty")</div>
-                }
-            </div>
-
             <div class="milestone-desc">
                 <div markdown="true" class="markdown-wrap">@milestone.contents</div>
                 <div class="attachments" data-resourceType="@ResourceType.MILESTONE" data-resourceId="@milestone.id"></div>
app/views/user/partial_milestones.scala.html
--- app/views/user/partial_milestones.scala.html
+++ app/views/user/partial_milestones.scala.html
@@ -24,31 +24,23 @@
             <span class="due-date">@Messages("label.dueDate") <strong>@milestone.getDueDateString</strong></span>
             <span class="date">(@milestone.until)</span>
             }
-            <div class="issue-wrap nbtn-group pull-right">
-                <a href="@makeIssuesLink(milestone.id,"open")" class="nbtn medium">
-                @Messages("issue.state.open") <strong class="num-badge open">@milestone.getNumOpenIssues</strong>
+            <div class="pull-right">
+                <a href="@makeIssuesLink(milestone.id,"open")">
+                @Messages("issue.state.open") <strong class="numberic nm">@milestone.getNumOpenIssues</strong>
                 </a>
-                <a href="@makeIssuesLink(milestone.id,"closed")" class="nbtn medium">
-                @Messages("issue.state.closed") <strong class="num-badge closed">@milestone.getNumClosedIssues</strong>
+                <a href="@makeIssuesLink(milestone.id,"closed")" class="ml10">
+                @Messages("issue.state.closed") <strong class="numberic nm">@milestone.getNumClosedIssues</strong>
                 </a>
             </div>
         </div>
 
         <div class="progress-wrap">
-            <div class="progress">
-                <div class="bar orange" style="width: @milestone.getCompletionRate%;"></div>
-            </div>
-            <div class="progress-label">
-                <div class="pull-left" style="width: @milestone.getCompletionRate%; min-width:100px;">
-                    <a href="@makeIssuesLink(milestone.id,"closed")">@Messages("issue.state.closed") <strong>@milestone.getCompletionRate%</strong></a>
-                </div>
-                <div class="pull-right">
-                    <a href="@makeIssuesLink(milestone.id,"open")">@Messages("issue.state.open") <strong>@{100 - milestone.getCompletionRate}%</strong></a>
-                </div>
+            <div class="progress progress-success progress-striped active">
+                <div class="bar" style="width: @milestone.getCompletionRate%;"></div>
             </div>
         </div>
     </div>
-    <div class="completion-rate @if(milestone.getCompletionRate == 100){done}"><!--
+    <div class="completion-rate"><!--
              -->@milestone.getCompletionRate<!--
              --><i>%</i>
     </div>
Add a comment
List