Jihan Kim
2014-04-11
Fix incorrect data attribute name
All HTML attribute names should get ASCII-lowercased, and $.data() can take unintended behaviors with camel-cased custom data attribute names.
@62047422d2ef5ef8cc883dd1918ae58dfe16f1d7
--- app/views/board/partial_comments.scala.html
+++ app/views/board/partial_comments.scala.html
... | ... | @@ -63,7 +63,7 @@ |
| 63 | 63 |
|
| 64 | 64 |
<div id="comment-body-@comment.id"> |
| 65 | 65 |
<div class="comment-body markdown-wrap markdown-before" markdown="true">@comment.contents</div> |
| 66 |
- <div class="attachments pull-right" data-resourceType="@ResourceType.NONISSUE_COMMENT" data-resourceId="@comment.id"></div> |
|
| 66 |
+ <div class="attachments pull-right" data-resource-type="@ResourceType.NONISSUE_COMMENT" data-resource-id="@comment.id"></div> |
|
| 67 | 67 |
</div> |
| 68 | 68 |
</div> |
| 69 | 69 |
</li> |
--- app/views/board/view.scala.html
+++ app/views/board/view.scala.html
... | ... | @@ -40,7 +40,7 @@ |
| 40 | 40 |
</div> |
| 41 | 41 |
</div> |
| 42 | 42 |
<div class="content markdown-wrap markdown-before" markdown="true">@post.body</div> |
| 43 |
- <div class="attachments" id="attachments" data-resourceType="@ResourceType.BOARD_POST" data-resourceId="@post.id"></div> |
|
| 43 |
+ <div class="attachments" id="attachments" data-resource-type="@ResourceType.BOARD_POST" data-resource-id="@post.id"></div> |
|
| 44 | 44 |
</div> |
| 45 | 45 |
<div class="board-footer board-actrow"> |
| 46 | 46 |
<div class="pull-left"> |
--- app/views/code/partial_nonrange_codecomment_thread.scala.html
+++ app/views/code/partial_nonrange_codecomment_thread.scala.html
... | ... | @@ -53,7 +53,7 @@ |
| 53 | 53 |
</div> |
| 54 | 54 |
|
| 55 | 55 |
<div class="comment-body markdown-wrap markdown-before" markdown="true">@comment.getContents</div> |
| 56 |
- <div class="attachments" data-resourceType="@comment.asResource.getType" data-resourceId="@comment.id"></div> |
|
| 56 |
+ <div class="attachments" data-resource-type="@comment.asResource.getType" data-resource-id="@comment.id"></div> |
|
| 57 | 57 |
</div> |
| 58 | 58 |
</li> |
| 59 | 59 |
} |
--- app/views/code/svnDiff.scala.html
+++ app/views/code/svnDiff.scala.html
... | ... | @@ -119,7 +119,7 @@ |
| 119 | 119 |
|
| 120 | 120 |
<div class="comment-body markdown-wrap markdown-before" markdown="true">@comment.contents</div> |
| 121 | 121 |
|
| 122 |
- <div class="attachments" data-resourceType="@ResourceType.COMMIT_COMMENT" data-resourceId="@comment.id"></div> |
|
| 122 |
+ <div class="attachments" data-resource-type="@ResourceType.COMMIT_COMMENT" data-resource-id="@comment.id"></div> |
|
| 123 | 123 |
</div> |
| 124 | 124 |
</li> |
| 125 | 125 |
} |
--- app/views/git/view.scala.html
+++ app/views/git/view.scala.html
... | ... | @@ -17,7 +17,7 @@ |
| 17 | 17 |
<div class="span9"> |
| 18 | 18 |
@partial_branch(pull) |
| 19 | 19 |
<div class="content markdown-wrap markdown-before" markdown="true">@pull.body</div> |
| 20 |
- <div class="attachments" data-resourceType="@ResourceType.PULL_REQUEST" data-resourceId="@pull.id"></div> |
|
| 20 |
+ <div class="attachments" data-resource-type="@ResourceType.PULL_REQUEST" data-resource-id="@pull.id"></div> |
|
| 21 | 21 |
</div> |
| 22 | 22 |
<div class="span3"> |
| 23 | 23 |
<div class="author-info"> |
--- app/views/issue/partial_comments.scala.html
+++ app/views/issue/partial_comments.scala.html
... | ... | @@ -100,7 +100,7 @@ |
| 100 | 100 |
|
| 101 | 101 |
<div id="comment-body-@comment.id"> |
| 102 | 102 |
<div class="comment-body markdown-wrap markdown-before" markdown="true">@comment.contents</div> |
| 103 |
- <div class="attachments pull-right" data-resourceType="@ResourceType.ISSUE_COMMENT" data-resourceId="@comment.id"></div> |
|
| 103 |
+ <div class="attachments pull-right" data-resource-type="@ResourceType.ISSUE_COMMENT" data-resource-id="@comment.id"></div> |
|
| 104 | 104 |
</div> |
| 105 | 105 |
</div> |
| 106 | 106 |
</li> |
--- app/views/issue/view.scala.html
+++ app/views/issue/view.scala.html
... | ... | @@ -74,7 +74,7 @@ |
| 74 | 74 |
} else {
|
| 75 | 75 |
<div class="content markdown-wrap markdown-before" markdown="true">@issue.body</div> |
| 76 | 76 |
} |
| 77 |
- <div class="attachments" id="attachments" data-resourceType="@ResourceType.ISSUE_POST" data-resourceId="@issue.id"></div> |
|
| 77 |
+ <div class="attachments" id="attachments" data-resource-type="@ResourceType.ISSUE_POST" data-resource-id="@issue.id"></div> |
|
| 78 | 78 |
</div> |
| 79 | 79 |
|
| 80 | 80 |
<div class="span3 mb20"> |
--- app/views/milestone/view.scala.html
+++ app/views/milestone/view.scala.html
... | ... | @@ -39,7 +39,7 @@ |
| 39 | 39 |
</div> |
| 40 | 40 |
<div class="milestone-desc"> |
| 41 | 41 |
<div markdown="true" class="markdown-wrap">@milestone.contents</div> |
| 42 |
- <div class="attachments" data-resourceType="@ResourceType.MILESTONE" data-resourceId="@milestone.id"></div> |
|
| 42 |
+ <div class="attachments" data-resource-type="@ResourceType.MILESTONE" data-resource-id="@milestone.id"></div> |
|
| 43 | 43 |
</div> |
| 44 | 44 |
|
| 45 | 45 |
<div id="issues"> |
--- app/views/partial_comment_thread.scala.html
+++ app/views/partial_comment_thread.scala.html
... | ... | @@ -63,7 +63,7 @@ |
| 63 | 63 |
</div> |
| 64 | 64 |
|
| 65 | 65 |
<div class="comment-body markdown-wrap markdown-before" markdown="true">@comment.getContents</div> |
| 66 |
- <div class="attachments" data-resourceType="@comment.asResource.getType" data-resourceId="@comment.id"></div> |
|
| 66 |
+ <div class="attachments" data-resource-type="@comment.asResource.getType" data-resource-id="@comment.id"></div> |
|
| 67 | 67 |
</div> |
| 68 | 68 |
</li> |
| 69 | 69 |
} |
Add a comment
Delete comment
Once you delete this comment, you won't be able to recover it. Are you sure you want to delete this comment?