Commit @226d709101e9dbad1027293497028ef8b52e6435

doortts 2017-02-06

my-issues: Fix 'commented by me' filter bug

@226d709101e9dbad1027293497028ef8b52e6435

ef929ab

226d709

app/models/support/SearchCondition.java

--- app/models/support/SearchCondition.java

+++ app/models/support/SearchCondition.java


     private List<Long> getCommentedIssueIds(User commenter, Project project) {
         Set<Long> issueIds = new HashSet<>();
 
-        for (Comment comment : IssueComment.find.where()
+        List<IssueComment> comments = IssueComment.find.where()
                 .eq("authorId", commenter.id)
-                .findList()) {
-            if (project == null) {
+                .findList();
+        if (project == null) {
+            for (Comment comment : comments) {
                 issueIds.add(comment.getParent().id);
-                break;
-            } else {
+            }
+        } else{
+            for (Comment comment : comments) {
                 if (comment.projectId.equals(project.id)) {
                     issueIds.add(comment.getParent().id);
                 }

Add a comment

Open 0
Closed 0

List

...	...	@@ -323,13 +323,15 @@
323	323	private List<Long> getCommentedIssueIds(User commenter, Project project) {
324	324	Set<Long> issueIds = new HashSet<>();
325	325
326		- for (Comment comment : IssueComment.find.where()
	326	+ List<IssueComment> comments = IssueComment.find.where()
327	327	.eq("authorId", commenter.id)
328		- .findList()) {
329		- if (project == null) {
	328	+ .findList();
	329	+ if (project == null) {
	330	+ for (Comment comment : comments) {
330	331	issueIds.add(comment.getParent().id);
331		- break;
332		- } else {
	332	+ }
	333	+ } else{
	334	+ for (Comment comment : comments) {
333	335	if (comment.projectId.equals(project.id)) {
334	336	issueIds.add(comment.getParent().id);
335	337	}

Delete comment